REVIEW 3 major objections 4 minor 1 cited by
Computing Hilbert modular forms as orthogonal modular forms
T0 review · 3 major / 4 minor · reviewed 2026-08-06 · deepseek-v4-flash
Pith's one-line read Even-weight Hilbert modular newforms can be computed through ternary quadratic forms, with each Atkin–Lehner sign sector obtained by a radical character.
desk verdict Strong algorithmic paper with a genuinely new idea (the radical character), but the one-sentence proof of Theorem 7.5 leaves a real gap in the newform theory that needs to be closed before the main theorem is established. read the letter →
The pith
A machine-rendered reading of the paper's core claim, the machinery that carries it, and where it could break.
The reading
What carries the argument
The even Clifford algebra functor $\Lambda \mapsto \mathrm{Clf}^0(\Lambda)$ from integral ternary quadratic lattices to quaternion orders, which identifies the class set of $\Lambda$ with the type set of $\mathcal{O}$; and the radical character $\nu_p : SO(\Lambda_p) \to \{\pm 1\}$, defined by the action of an isometry on the line $\mathrm{rad}(\Lambda_p)/2N\Lambda_p$ and extended multiplicatively to $\nu_M$. The functor makes the orthogonal and quaternionic Hecke modules canonically isomorphic, and the radical character selects the Atkin–Lehner eigenspace that the Hilbert newforms occupy. On the computational side, Kneser's $p$-neighbor method and reduction of ternary quadratic forms supply the Hecke operators.
What would settle it
For a composite squarefree level such as $N=33$ over $\mathbb{Q}$, compute the degeneracy matrix between the radical-character component $\nu_r$ on $\mathrm{Cl}(\Lambda)$ and the component for a super-lattice $\Lambda'$ via the pullback defined in Section 7; if the matrix is not diagonal with respect to the Atkin–Lehner eigenvalues, the new subspace obtained by restricting Corollary 6.12 is not the Hilbert new space. A simpler check: the multiplicities from Proposition 4.20 predict the dimensions of $S_k^{\mathrm{new}}(\Gamma_0(33))_\varepsilon$, and comparing those dimensions with the output of an orthogonal implementation for each $\varepsilon$ would settle the one-sentence step in Theorem 7.5.
Extended reading notes
Core claim
On the paper's own terms, the central discovery is that the missing half of Birch's method is supplied by a character: for each Atkin–Lehner sign vector $\varepsilon$ the paper defines a radical character $\nu_\varepsilon$ on the special orthogonal group of a ternary lattice, and proves (Theorem 1.4, generalized in Theorem 7.5) a Hecke-equivariant bijection between the cuspidal orthogonal modular forms $S_k(SO(\Lambda), \nu_\varepsilon)$ and the quaternionic forms $S_k(\widehat{O})_\varepsilon$ with Atkin–Lehner signs $\varepsilon$. Combined with the Eichler–Shimizu–Jacquet–Langlands correspondence (Theorem 4.10), this yields all spaces $S_k^{\mathrm{new}}(\Gamma_0(N))_\varepsilon$ whenever a suitable quaternion order exists, i.e., unless $[F:\mathbb{Q}]$ is odd and $N$ is a square. The bijection is canonical because the even Clifford algebra functor sends class sets of ternary lattices to type sets of quaternion orders, so the two function spaces are literally identified; the radical character files the classes according to the action on the one-dimensional radical of the $p$-adic lattice, which matches the Atkin–Lehner signs.
Load-bearing premise
The load-bearing premise is one sentence in the proof of Theorem 7.5: restricting the bijection of Corollary 6.12 to new subspaces preserves the radical-character labeling, so that the orthogonal degeneracy maps behave exactly like the quaternionic ones; if those maps mix the $\nu_\varepsilon$ components, the computed new space would be the wrong Hecke module.
Editorial extensions
If this is right
- For any totally real field $F$, even weight $k$, factored level $N$ with $[F:\mathbb{Q}]$ even or $N$ nonsquare, and any sign vector $\varepsilon$, the new space $S_k^{\mathrm{new}}(\Gamma_0(N))_\varepsilon$ is exhibited as a Hecke module by matrices obtained from ternary lattice classes.
- The Hecke matrices are sparse, and the running time for $T_p$ is $\widetilde{O}(d^2 \operatorname{Nm}(p))$ for fixed $F,N$, reducing to $\widetilde{O}(d \operatorname{Nm}(p))$ after lattice setup, so the cost is roughly linear in the dimension $d$ of the output space.
- The two deficiencies Birch identified—retrieving only half the forms and losing information when the level is not squarefree—are both removed: every Atkin–Lehner eigenspace is obtained, for arbitrary level outside the square-odd-degree exception.
- The dimension of each $\varepsilon$-eigenspace is asymptotically $2^{-r} \operatorname{Nm}(N) |k-1|$ by the mass formula, so splitting the new space by sign vectors does not make any individual piece asymptotically negligible.
Reading between the lines
- The radical-character construction is likely to adapt to nontrivial central characters or bounded level: the paper's framework already handles residually unramified orders, and its Remark 4.9 points toward residually ramified orders as a further extension.
- Because the spinor norm has the explicit formula $\theta(\sigma)=1+\operatorname{tr}(\sigma)$ in dimension three, the radical character can be evaluated directly from the trace of an isometry, which may simplify implementations and extend the method to lattices whose Clifford order is not residually unramified.
- A natural test beyond the paper is to compare the orthogonal-side output with quaternionic or modular-symbol computations at composite levels where the old subspace has several layers; the multiplicity formula in Proposition 4.20 predicts exactly which newforms appear in each component.
- The speed demonstrated on $F=\mathbb{Q}$ suggests that sampling Hecke eigenvalues in a fixed Atkin–Lehner eigenspace could make searches for elliptic curves of moderately large conductor practical, an application the authors hint at but do not develop.
Editorial analysis
A structured set of objections, weighed in public.
Referee Report
Summary. The paper presents an algorithm to compute Hilbert modular forms of even weight and trivial central character as orthogonal modular forms on a totally definite ternary quadratic space, extending Birch's method to totally real fields, nonsquare levels, and all Atkin-Lehner eigenspaces. The main theoretical result, Theorem 1.4, is a Hecke-equivariant bijection between cuspidal orthogonal modular forms with a radical character and quaternionic cusp forms with specified Atkin-Lehner eigenvalues; Theorem 7.5 upgrades this to new subspaces. The paper further gives a complexity analysis, an algorithm for constructing suitable lattices and orders, and reports on implementations in Magma and C++. The main advertised computational output is Theorem 1.3: for a totally real field F, even weight k, factored level N with [F:Q] even or N nonsquare, and sign vector ε, the new space S_new_k(bΓ0(N))_ε can be computed as a Hecke module with running time eO(d^2 Nm(p)) for T_p, where d is the dimension of the output space.
Significance. If the main theorems are correct, this is a substantial advance: it gives a uniform, practical method for computing Hilbert modular forms in cases where modular symbols are expensive or infeasible, and it resolves both known limitations of Birch's ternary-form method by introducing the radical character. The even Clifford algebra approach is conceptually transparent and provides a canonical, Hecke-equivariant correspondence without analytic theta-series arguments. The paper also contains an explicit categorical inverse to the even Clifford functor (Appendix A) and concrete computational examples, including a large-level example that outperforms modular symbols. These are real strengths. However, the proof of the newform-theoretic bridge, Theorem 7.5, is currently a one-sentence assertion, and this is load-bearing for the advertised output; the complexity statement also contains an internal inconsistency. The underlying strategy appears defensible, but the manuscript as submitted does not yet establish the central claim.
major comments (3)
- [§7, Theorem 7.5] The proof of Theorem 7.5 is a single sentence: 'We restrict Corollary 6.12 to the new subspace on quaternionic modular forms; by definition, this corresponds to the new subspace on orthogonal modular forms.' This is not sufficient. Corollary 6.12 gives a Hecke-equivariant bijection between the full spaces M_k(SO(bΛ), νM) and M_k(bO)_{εM}. The orthogonal old subspace, by Definition 7.4, is generated by pullbacks α_Λ' from lattices Λ' corresponding to superorders O' ⊇ O, with SO(bΛ) ≤ SO(bΛ'). To restrict Corollary 6.12 to new subspaces, one must prove that these degeneracy maps are compatible with the radical character: for each such Λ' there should be a character ν'_M on SO(bΛ') whose restriction to SO(bΛ) equals νM, and the induced map should land in M_k(SO(bΛ), νM). The manuscript does not define such characters on the superorder lattices, does not prove that νM extends or restricts in the required way, and does not show that the orthogonal old subspace corresponds, under Corollary 6.12, to the quaternionic old subspace generated by pullbacks from O' ⊇ O. Without this compatibility, the orthogonal complement computed by the algorithm is not identified with S_new_k(bΓ0(N))_ε. This is the only place where the space actually computed (orthogonal new space with radical character) is connected to the space advertised in Theorem 1.3 (Hilbert new space with Atkin-Lehner signs), so the gap is load-bearing.
- [§1, Theorem 1.3 and following paragraph] The complexity statement is internally inconsistent. Theorem 1.3 states that, for fixed F and N, the algorithm takes eO(d^2 Nm(p)) bit operations to compute T_p, where d = dim_C S_new_k(bΓ0(N))_ε. The paragraph immediately after Theorem 1.3 claims: 'After a precomputation (to set up the lattice), the running time becomes eO(d Nm(p))'. These two displayed statements cannot both be true with the same meaning of d. Theorem 8.5 gives yet another expression, eO(Nm(p) H_{3n}(∥Λ∥ d^2)), where d = #Cl(Λ), which is not obviously reconciled with either statement in §1. The authors should state clearly the worst-case cost, the amortized cost after precomputation, and the precise role of the output dimension d in each formula.
- [§7, Definition 7.4 and §6, Corollary 6.12] Related to the gap in Theorem 7.5, the definition of the orthogonal old subspace is not extended to the radical-character twisted setting. Definition 7.4 defines the old subspace inside M_W(SO(bΛ)) using degeneracy maps α_Λ' that pull back untwisted functions from SO(bΛ')-invariant classes. But the spaces in Corollary 6.12 and Theorem 7.5 are the twisted spaces M_k(SO(bΛ), νM). The paper never states what the degeneracy maps are on these twisted spaces, which character on the superorder lattice Λ' is used, or why the images land in the νM-isotypic component rather than mixing different radical characters. This is not just a presentational gap: if the radical character mixes under pullback, the orthogonal complement of the old subspace in M_k(SO(bΛ), νM) need not be the νM-component of the new space, and Theorem 7.5 would fail. A complete proof should include a commutative diagram for the degeneracy maps on both sides.
minor comments (4)
- [§3, Remark 3.9] The phrase 'isotopic decomposition' should be 'isotypic decomposition'.
- [§6, equation (6.3)] The symbol O is overloaded: on the right-hand side of (6.3), O(rad_p(Λ)/2NΛ_p) denotes the orthogonal group, while elsewhere O denotes a quaternion order. Using a different symbol, such as Aut or Orth, would avoid confusion.
- [§8, Theorem 8.5] The role of d = #Cl(Λ) in the Hermite normal form complexity H_{3n}(∥Λ∥ d^2) is not explained; in particular, it is unclear whether the factor d^2 is a worst-case bound for the size of the lattice entries after reduction, and how this relates to the dimension d of the output space in Theorem 1.3.
- [§1, theorem statement] Theorem 1.3 promises to 'return for each ideal n coprime to N a matrix [T_n]', but the algorithms and complexity analysis in §8 only discuss the prime Hecke operator T_p. The authors should state how composite T_n are obtained (e.g., by the standard recurrence from the T_p for p not dividing N), or otherwise clarify the scope of the theorem.
Circularity Check
No significant circularity: the radical character is proved to match the Atkin–Lehner sign decomposition, and the algorithm's output is not fitted to its input.
full rationale
The derivation is self-contained in the relevant sense. The radical character νp is defined canonically from the lattice in (6.1)–(6.3), and Proposition 6.8 proves that the pairing with the normalizer is perfect and identifies the radical character with the Atkin–Lehner involution signs; Corollary 6.12 then gives the Hecke-equivariant bijection with the quaternionic ε-eigenspace. No parameter is fitted to any data set, and the sign vector ε is an input, not a quantity inferred from the output. The main structural input, the even-Clifford bijection Cl Λ ↔ Typ O, is imported from Voight's monograph [Voi21] and developed further in Appendix A; although Voight is an author, these are published theorem references with independent mathematical content, so the self-citations are not load-bearing in a circular sense. The one genuinely weak passage is the proof of Theorem 7.5, which says: 'We restrict Corollary 6.12 to the new subspace on quaternionic modular forms; by definition, this corresponds to the new subspace on orthogonal modular forms.' That is an omitted proof that the orthogonal degeneracy maps preserve the νM-isotypic components, not a circular reduction: the conclusion is not assumed in Definition 7.4, and a failure there would make the advertised new-space identification false rather than tautologically true. The implementation is also checked against known newforms in Section 9, providing external, non-circular evidence. I therefore find no definitional or fitted-input circularity.
Assumptions & free parameters
assumptions (4)
- standard math Eichler-Shimizu-Jacquet-Langlands correspondence for suitable quaternion orders (Theorem 4.10).
- standard math Even Clifford algebra functor gives bijections between ternary lattices and Gorenstein quaternion orders (Theorem 5.7, Corollary 5.8, Appendix A).
- standard math Kneser's method of p-neighbors computes the class set and the Hecke action (Section 2, Section 8).
- domain assumption The input must satisfy that either [F:Q] is even or N is nonsquare, so a suitable quaternion algebra exists (Proposition 4.5).
Cite this review
Pith. "Pith review of Computing Hilbert modular forms as orthogonal modular forms." pith.science (2026). https://pith.science/paper/J6AH73DP
@misc{pith2026250621981,
author = {Pith},
title = {Pith review of: Computing Hilbert modular forms as orthogonal modular forms},
year = {2026},
howpublished = {\url{https://pith.science/paper/J6AH73DP}},
note = {Machine review of arXiv:2506.21981}
}
read the original abstract
We show how to efficiently compute Hilbert modular forms as orthogonal modular forms, generalizing and expanding upon the method of Birch.
Forward citations
Cited by 1 Pith paper
-
An orthogonal perspective on Gauss composition
Clifford and norm functors give a discriminant-preserving equivalence between binary quadratic modules and pseudoregular modules over quadratic algebras, recovering and generalizing Gauss composition over any base scheme.
Reference graph
Works this paper leans on
-
[1]
Eran Assaf, Dan Fretwell, Colin Ingalls, Adam Logan, Spencer Secord, and John Voight, Definite orthogonal modular forms: computations, excursions, and discoveries, Res.\ Number Theory 8:70 (2022), 38 pages
work page 2022
-
[2]
Alex J.\ Best, Jonathan Bober, Andrew R.\ Booker, Edgar Costa, John Cremona, Maarten Derickx, David Lowry-Duda, Min Lee, David Roe, Andrew V.\ Sutherland, and John Voight, Computing classical modular forms, eds.\ Jennifer S.\ Balakrishnan, Noam Elkies, Brendan Hassett, Bjorn Poonen, Andrew V.\ Sutherland, and John Voight, Simons Symp., Springer, Cham, 202...
work page 2021
-
[3]
Manjul Bhargava, Higher composition laws. III. The parametrization of quartic rings, Ann. of Math. (2) 159 (2004), no. 3, 1329--1360
work page 2004
-
[4]
B.J. Birch, Hecke actions on classes of ternary quadratic forms, Computational number theory: proceedings of the colloquium on Computational Number Theory held at Kossuth Lajos University, Debrecen (Hungary, 1989), W. de Gruyter, Berlin, 1991, 191--212
work page 1989
-
[5]
Siegfried B\"ocherer and Rainer Schulze-Pillot, Siegel modular forms and theta series attached to quaternion algebras, Nagoya Math.\ J.\ 121 (1991), 35--96
work page 1991
-
[6]
Wieb Bosma, John Cannon, and Catherine Playoust, The Magma algebra system.\ I.\ The user language, J.\ Symbolic Comput.\ 24 (1997), vol.\ 3--4, 235--265
work page 1997
-
[7]
Alex Cowan, Computing newforms using supersingular isogeny graphs, Res.\ Number Theory 8 (2022), no.\ 4, Paper No.\ 96, 23 pp
work page 2022
-
[8]
J.E.\ Cremona, Algorithms for modular elliptic curves, 2nd.\ ed., Cambridge University Press, Cambridge, 1997
work page 1997
Show all 36 references
-
[9]
348, 1805--1858
Neil Dummigan, Ariel Pacetti, Gustavo Rama, and Gonzalo Tornar\'ia, Quinary forms and paramodular forms, Math.\ Comp.\ 93 (2024), no. 348, 1805--1858
2024
-
[10]
63, Springer-Verlag, Berlin-New York, 1974
Martin Eichler, Quadratische Formen und orthogonale Gruppen, second ed., Grund\-lehren Math.\ Wiss., vol. 63, Springer-Verlag, Berlin-New York, 1974
1974
-
[11]
Lassina Demb\'el\'e, Explicit methods for Hilbert modular forms, Elliptic curves, Hilbert modular forms and Galois deformations, Birkhauser, Basel, 2013, 135--198
2013
-
[12]
aren quadratischen Formen, nebst den Resultaten neuer Forschungen \
G. Eisenstein, Tabelle der reducirten positiven tern\"aren quadratischen Formen, nebst den Resultaten neuer Forschungen \"uber diese Formen, in besonderer R\"ucksicht auf ihre tabellarische Berechnung, J.\ Reine Angew.\ Math.\ 41 (1851), 141--190
-
[13]
1, eds.\ A
Stephen Gelbart and Herv\'e Jacquet, Forms of GL(2) from the analytic point of view, Automorphic forms, representations and L-functions (Corvallis, OR, 1977), vol. 1, eds.\ A. Borel and W. Casselman, Proc.\ Sympos.\ Pure Math.\ 33, Amer.\ Math.\ Soc., Providence, RI, 1979, 213--251
1977
-
[14]
6, Springer, Berlin, 2014, 147--179
Matthew Greenberg and John Voight, Lattice methods for algebraic modular forms on classical groups, Computations with modular forms, eds.\ Gebhard Boeckle and Gabor Wiese, Contrib.\ Math.\ Comput.\ Sci., vol. 6, Springer, Berlin, 2014, 147--179
2014
-
[15]
Gross, Local orders, root numbers, and modular curves, Amer
Benedict H. Gross, Local orders, root numbers, and modular curves, Amer. J. Math. 110 (1988), no. 6, 1153--1182
1988
-
[16]
Benedict H.\ Gross, Algebraic modular forms, Isr. J. Math.\ 113 (1999), 61--93
1999
-
[17]
Gross and Mark W
Benedict H. Gross and Mark W. Lucianovic, On cubic rings and quaternion rings, J. Number Theory 129 (2009), no. 6, 1468--1478
2009
-
[18]
Ishay Haviv and Oded Regev, On the lattice isomorphism problem, Proceedings of the Twenty-Fifth Annual ACM-SIAM Symposium on Discrete Algorithms, ACM, New York, 2014, 391--404
2014
-
[19]
Jeffery Hein, Orthogonal modular forms: an application to a conjecture of Birch, algorithms and computations, PhD thesis, Dartmouth College, 2016
2016
-
[20]
Jeffery Hein, ternary-birch, https://github.com/jefferyphein/ternary-birch, accessed 26 June 2024
2024
-
[21]
4, 727--776
Haruzo Hida, On abelian varieties with complex multiplication as factors of the Jacobians of Shimura curves, Amer.\ J.\ of Math.\ 103 (1981), no. 4, 727--776
1981
-
[22]
Langlands, Automorphic forms on GL(2), Lect.\ Notes in Math., vol
Herv\'e Jacquet and Robert P. Langlands, Automorphic forms on GL(2), Lect.\ Notes in Math., vol. 114, Springer-Verlag, Berlin, 1970
1970
-
[23]
Martin Kneser, Klassenzahlen definiter quadratischer Formen, Arch.\ Math.\ 8 (1957), 241--250
1957
-
[24]
Kimball Martin, Refined dimensions of cusp forms, and equidistribution and bias of signs, J.\ Number Theory 188 (2018), 1--17
2018
-
[25]
Kimball Martin, The basis problem revisited, Trans.\ Amer.\ Math.\ Soc.\ 373 (2020), no.\ 7, 4523--4559
2020
-
[26]
2, 99--116
Arnold Pizer, The action of the canonical involution on modular forms of weight 2 on 0 (M) , Math.\ Ann.\ 226 (1977), no. 2, 99--116
1977
-
[27]
Paul Ponomarev, Ternary quadratic forms and Shimura's correspondence, Nagoya Math.\ J.\ 81 (1981), 123--151
1981
-
[28]
1918, Springer, Berlin, 2007
Brooks Roberts and Ralf Schmidt, Local newforms for GSp(4) , Lect.\ Notes in Math., vol. 1918, Springer, Berlin, 2007
1918
-
[29]
3, 507--517
Alexander Schiemann, Ternary positive definite quadratic forms are determined by their theta series, Math.\ Ann.\ 308 (1997), no. 3, 507--517
1997
-
[30]
Rainer Schulze-Pillot, Ternary quadratic forms and Brandt matrices, Nagoya Math.\ J.\ 102 (1986), 117--126
1986
-
[31]
Gonzalo Tornar\'ia, The Brandt module of ternary quadratic lattices, PhD thesis, University of Texas, Austin, 2005
2005
-
[32]
John Voight, Characterizing quaternion rings over an arbitrary base, J.\ Reine Angew.\ Math.\ 657 (2011), 113--134
2011
-
[33]
K.\ Alladi, M.\ Bhargava, D.\ Savitt, and P.H.\ Tiep, Developments in Math., vol
John Voight, Identifying the matrix ring: algorithms for quaternion algebras and quadratic forms, Quadratic and higher degree forms, eds. K.\ Alladi, M.\ Bhargava, D.\ Savitt, and P.H.\ Tiep, Developments in Math., vol. 31, Springer, New York, 2013, 255--298
2013
-
[34]
288, Springer, Cham, 2021
John Voight, Quaternion algebras, Grad.\ Texts in Math., vol. 288, Springer, Cham, 2021
2021
-
[35]
John Voight, Kneser's method of neighbors, Arch.\ Math.\ (Basel) 121 (2023), 537--557
2023
-
[36]
Hans Zassenhaus, On the spinor norm, Arch.\ Math.\ 13 (1962), 434--451
1962
Reviewed August 6, 2026 · model on record in the stance chip above.
Discussion (0). Continue with ORCID to comment.